cwrc / cwrc-entity-management-forms-static

1 stars 1 forks source link

In the source bibl, if both author and title are retrieved, wrap them in corresponding tags #43

Open ilovan opened 6 years ago

ilovan commented 6 years ago

Expected Behaviour

                    <listBibl>
                        <bibl><author>Sagendorf, Bud</author>. <title>Popeye, the first fifty years</title><ref
                                source="VIAF"
                                target="http://viaf.org/viaf/6336151965298200470006/"/></bibl>
                    </listBibl>

Current Behaviour

                    <listBibl>
                        <bibl><title>Sagendorf, Bud,. | Popeye, the first fifty years</title><ref
                                source="VIAF"
                                target="http://viaf.org/viaf/6336151965298200470006/"/></bibl>
                    </listBibl>

Examples

ajmacdonald commented 6 years ago

This would be difficult to implement because of how our entity lookups work. They all return standardized data with the following fields: entity type, URI, entity name/label, and lookup repository. So from the perspective of the forms, we don't have access to the full response from the repository.

ilovan commented 6 years ago

Then let's go with

                    <listBibl>
                        <bibl>Sagendorf, Bud,. | Popeye, the first fifty years<ref
                                source="VIAF"
                                target="http://viaf.org/viaf/6336151965298200470006/"/></bibl>
                    </listBibl>
ajmacdonald commented 6 years ago

60c5e7c089497a8db7040661b9b4e116d33aae2a

ilovan commented 4 years ago

confirmed on dev-02.cwrc.ca