For XSLTs that modify an existing datastream, if the user fills in the workflow form when prompted, the next screeen is the main view of the object and there is no confirmation message that the transform worked.

cwrc / cwrc_xslt

A drupal module to add or update existing islandora object using an XSLT

https://cwrc.ca

GNU General Public License v2.0

0 stars 0 forks source link

For XSLTs that modify an existing datastream, if the user fills in the workflow form when prompted, the next screeen is the main view of the object and there is no confirmation message that the transform worked. #3

Open ilovan opened 5 years ago

ilovan commented 5 years ago

Expected Behaviour

also with "workflow stamp successfully added" Drupal confirmation message

Current Behaviour

Possible Solution

It seems that the workflow module prescribed behaviour is overriding the xslt module message

Steps to Reproduce (for bugs)

Go to object
Lock object
Go to Manage > Add/Change a datastream using XSLT
Select the CWRC source datastream.

Your Environment

URL: https://dev-01.cwrc.ca/islandora/object/islandora%3A3d0994b6-a20e-43bc-ac8e-ebb0f0c8a395

nikathone commented 5 years ago

Fix in https://github.com/cwrc/cwrc_xslt/commit/2a67d3aa937ceb0589735a86949067fd7655ed14

ilovan commented 5 years ago

nope - still doing it (after cache cleared)

nikathone commented 5 years ago

It's not the xslt module which is triggering the workflow form window. You can notice in the background of the workflow form window that the the xslt module have already finish it's redirect to the datastreams page. See screenshot Screen Shot 2019-03-19 at 1 29 02 PM

@ilovan do you know which module implemented this workflow? If it's a CWRC module then we need to open an issue there and say it shouldn't redirect or we should find a solution there.

nikathone commented 5 years ago

How should we change the text at https://github.com/cwrc/cwrc_workflow_de#L424 to make the logic clear to regular users?