cwrc / ontology

CWRC ontology - primary repository
13 stars 7 forks source link

Forebear graffle: final review #339

Closed SusanBrown closed 6 years ago

SusanBrown commented 6 years ago

Still pending identity decision, but pls review and will move to approved regardless.

alliyya commented 6 years ago

@SusanBrown is it possible to make the boxes wider to fit the uris all on one line, otherwise it looks a bit off being randomly broken apart.

cwrc:Person is not a term currently in the ontology as we have natural person (http://sparql.cwrc.ca/testing/cwrc#Natural Person) and fictional person (http://sparql.cwrc.ca/testing/cwrc#Fictional Person)

I've also added a comment on the png in the folder

SusanBrown commented 6 years ago

I was afraid you would say that. There isn’t space: the whole thing will have to be reshaped. But I take the point. Sigh.

On Apr 22, 2018, at 1:53 PM, Alliyya Mo notifications@github.com<mailto:notifications@github.com> wrote:

@SusanBrownhttps://github.com/SusanBrown is it possible to make the boxes wider to fit the uris all on one line, otherwise it looks a bit off being randomly broken apart.

cwrc:Person is not a term currently in the ontology as we have natural person (http://sparql.cwrc.ca/testing/cwrc#Natural Person) and fictional person (http://sparql.cwrc.ca/testing/cwrc#Fictional Person)

I've also added a comment on the png in the folder

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cwrc/ontology/issues/339#issuecomment-383399654, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhUoFsJkUu2QxZtJM7dj5fLB8sQx2aQks5trMODgaJpZM4Te8-t.

SusanBrown commented 6 years ago

@alliyya Revised version here: https://drive.google.com/open?id=11AX2KHrmuM-jRv1-sYsCusgghOyIFqBj Couldn't see comment on the png so may have missed some things.

alliyya commented 6 years ago

Other than Identity issue raised in #311, approved

SusanBrown commented 6 years ago

Needs updating to reflect identity decision

GurjapSingh commented 6 years ago

this has been updated to reflect identity changes