search

cwt-wa / cwt

Crespo’s Worms Tournament (CWT) is the most prestigious tournament of Team17’s strategy game title Worms Armageddon held annually since 2002.
https://cwtsite.com/
5 stars 2 forks source link

Tournament max rounds and three way final #246

Closed Zemke closed 3 years ago

Zemke commented 3 years ago

Tournament has two information: maxRounds and threeWay.

I think Tournament#maxRounds has a different result than what TreeService#getNumberOfPlayoffRoundsInTournament would give. This is to be investigated.

I saw that the current tournament in the production database had maxRound set to 4 and threeWay to true which is both wrong, I think. How did that happen? \ The other tournaments in the DB had these set to 5 and false respectively.

Then again there’s a test GameDetailDtoTest#localizePlayoffRound which expects round 1 with playoff rounds max to be “Last 16” which also seems to oppose what’s in the database.

I don’t know, all the values seem to mean the same but are differently calculated.

Use 973d1123f29f71bfa15bd29b9ca3b12143e2b4c3 for further work as it has the new internalized localization method.

Zemke commented 3 years ago

The whole configuration table idea is not useful. The configuration records targeting configuration regarding the current tournament should just be written to the current tournament.

Zemke commented 3 years ago

Follow-up #247