search

cwt-wa / cwt

Crespo’s Worms Tournament (CWT) is the most prestigious tournament of Team17’s strategy game title Worms Armageddon held annually since 2002.
https://cwtsite.com/
5 stars 2 forks source link

Get rid of khttp #266

Closed Zemke closed 3 years ago

Zemke commented 3 years ago

Not maintained anymore and same results can be achieved with Apache HttpComponents which is already a dep.

Zemke commented 3 years ago

There’s a Java 11 HttpClient.

Zemke commented 3 years ago

Compiler warnings

[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/core/MultipartFileToFile.kt: (10, 24) 'createTempFile(String = ..., String? = ..., File? = ...): File' is deprecated. Avoid creating temporary files in the default temp location with this function due to too wide permissions on the newly created file. Use kotlin.io.path.createTempFile instead or resort to java.io.File.createTempFile.
[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/domain/core/Unzip.kt: (15, 19) 'createTempDir(String = ..., String? = ..., File? = ...): File' is deprecated. Avoid creating temporary directories in the default temp location with this function due to too wide permissions on the newly created directory. Use kotlin.io.path.createTempDirectory instead.
[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/domain/stream/service/StreamService.kt: (70, 30) 'maxBy((T) -> R): T?' is deprecated. Use maxByOrNull instead.
[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/domain/stream/service/StreamService.kt: (96, 18) 'maxBy((T) -> R): T?' is deprecated. Use maxByOrNull instead.
[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/domain/stream/service/StreamService.kt: (124, 30) 'max(): T?' is deprecated. Use maxOrNull instead.
[WARNING] /Users/leo/Code/cwt-wa/cwt/cwt-spring/src/main/java/com/cwtsite/cwt/domain/stream/service/StreamService.kt: (127, 30) 'max(): T?' is deprecated. Use maxOrNull instead.
Zemke commented 3 years ago

npm build errors

RROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/time-ago.service.spec.ts
[tsl] ERROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/time-ago.service.spec.ts(19,38)
      TS2345: Argument of type '"now"' is not assignable to parameter of type 'never'.

ERROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/time-ago.service.spec.ts
[tsl] ERROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/time-ago.service.spec.ts(19,58)
      TS2345: Argument of type '() => Date' is not assignable to parameter of type 'DateConstructor[keyof T] extends Func ? DateConstructor[keyof T] : DateConstructor[keyof T] extends new (...args: infer A) => infer V ? (...args: A) => V : never'.

ERROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/message/chat.component.spec.ts
[tsl] ERROR in /Users/leo/Code/cwt-wa/cwt/cwt-angular/src/test/webapp/app/message/chat.component.spec.ts(36,28)
      TS2345: Argument of type '"authState"' is not assignable to parameter of type 'never'.