search

cx0810 / pe

0 stars 0 forks source link

Success message shown even though no edits were made #5

Open cx0810 opened 3 years ago

cx0810 commented 3 years ago

The success message for editing a contact is displayed even though no edits were made to the contact details.

As seen in the screenshot, the command contact edit John Doe p/91234567 e/johndoe@example.com results in a success message displayed, but no edits were made to the contact.

image.png

nus-se-bot commented 3 years ago

Team's Response

The success message shows that the command was successful rather than it changed the contents of the contact. In this case, it is not really a bug and is an intended feature.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If there are no changes to the contact details, there shouldn't be a success message displayed to users since the command did not complete any operations.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: There is no explanation from developer response but I do think that this is a bug that causes false positive results to users, and will hinder usage.