cx0810 / pe

0 stars 0 forks source link

Unable to add contacts to existing modules #9

Open cx0810 opened 3 years ago

cx0810 commented 3 years ago

Though there is a module edit function to edit the details of the module. It would be more convenient to allow users to directly add contacts into the module without having to go through the edit feature to make it more optimized for users. Else, users will have to key in all the names of existing people in the module again in order to add another contact.

For example, if Mary Doe and John Doe is in module CS1103 and user wishes to add Sara Doe into the module, user will have to input module edit m/CS1103 p/Mary Doe p/John Doe p/Sara Doe which is very inconvenient for users.

nus-se-bot commented 3 years ago

Team's Response

We considered this and decided in order to make the feature more user friendly we implemented auto complete, FzF and command history so that it is much easier for users to add these members.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The auto complete, FzF and command history might not necessarily be more user friendly.

Firstly, command history will not work after users exit the programme and enter again, meaning that users will not be able to retrieve what they input into the programme previously if they choose to quit the application. Moreover, if the command is very far back into the command history, it does not make sense for users to use this feature to replicate the previous input.

Secondly, the use of auto complete and FzF is not very intuitive for users. Users will have to enter a different mode in order to add a new contact to an existing module. The usage of auto complete and FzF is also not clear in the user guide, with no concrete examples of how these features will work in the application, making it difficult for users to follow.

Despite the presence of autocomplete, FzF and command history, there should be a command to add contacts to an existing module as this is a basic feature that should be present in the application.


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: This is a major design flaw that should have been incorporated into the programme. While there are enhancements (auto complete, FzF and command history), the basic CLI of adding a contact to a module does not exist.