search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

parse_pos problem with strings in files #868

Closed kglotfelty closed 2 months ago

kglotfelty commented 6 months ago

Re: helpdesk ticket 25220

There is a disconnect in the parse_pos routines when parsing a single string vs a file that contains strings for ra & dec column (ie in HMS format)

https://github.com/cxcsds/ciao-contrib/blob/de8e6c146c2741d023ecd205ad63595fcae483f7/ciao_contrib/parse_pos.py#L71

The _str routine returns a list, but the _file needs to treat it like a scalar value. Need to review/rework the logic so that both a single "ra dec" string works as well as file w/ "ra dec" strings.

DougBurke commented 6 months ago

I'm assuming this is not a stop-the-presses type situation?

kglotfelty commented 6 months ago

I don't think so. It's been that way for a long, long time and there's a work-around (use prop_precess to convert to degree; a few hoops to jump through but not bad). Fix should be simple, but not a today kind of thing -- just want to be careful and double check other usage.

DougBurke commented 6 months ago

Ta

On Mon, Apr 1, 2024 at 3:05 PM Ken Glotfelty @.***> wrote:

I don't think so. It's been that way for a long, long time and there's a work-around (use prop_precess to convert to degree; a few hoops to jump through but not bad). Fix should be simple, but not a today kind of thing -- just want to be careful and double check other usage.

— Reply to this email directly, view it on GitHub https://github.com/cxcsds/ciao-contrib/issues/868#issuecomment-2030368509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABW27X4RGBXAYKTYPB7IN3Y3GVYDAVCNFSM6AAAAABFR5XVVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGM3DQNJQHE . You are receiving this because you commented.Message ID: @.***>