cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

download_chandra_obsid: fix GET command when downloading from mirror #873

Closed kglotfelty closed 1 month ago

kglotfelty commented 5 months ago

This fixes #773

The fix is to change the GET argument. Instead of GETting the fully qualified URL, we just need to get the .path. The conn object has already opened the connection to the server -- irregarless if it is to CDA or to MIRROR_SITE. The change to use purl.path works both with CDA and MIRROR_SITE.

I'm actually kinda surprised that the CDA server is returning right file even with the "wrong" path .. but our web servers are ... well, let's say ... creatively configured :tm:.

DougBurke commented 1 month ago

I've come to the conclusion that I no longer care to understand what the different Python URL systems want to do in the privacy of their home...