search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

aplimits with sherpa 4.16.1 #880

Closed kglotfelty closed 4 months ago

kglotfelty commented 6 months ago

With the sherpa 4.16.1 changes that came into CIAOX this week we are getting a failure in the aplimits script:

> Traceback (most recent call last):
>   File "INSTALL/bin/aplimits", line 54, in <module>
>     from sherpa.utils import igam, lgam, bisection
> ImportError: cannot import name 'bisection' from 'sherpa.utils' (INSTALL/lib/python3.11/site-packages/sherpa/utils/__init__.py)
DougBurke commented 6 months ago

Argh. But that's why we have a test suite...

DougBurke commented 6 months ago

I htink we can just take the bisection code that was removed in https://github.com/sherpa/sherpa/pull/2015 and add it to the the script.

Unless we start finding it used elsewhere.

DougBurke commented 6 months ago

For reference, this is the commit we care about: https://github.com/sherpa/sherpa/pull/2015/commits/60ee61a115f4820e03b7264f4035a0d43f38d198

kglotfelty commented 6 months ago

The only other place I can think that might be using it would be the level3 stuff; but not sure where that code lives.

kglotfelty commented 4 months ago

closing since sherpa reverted change.