search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

minor tweak to build XSpec user model on CIAO 4.17b1 #885

Closed nplee closed 1 month ago

nplee commented 2 months ago

It should be an easy fix, he says after joyfully forgetting all the previous times an XSPEC change should have been easy... (@DougBurke)

Fortunately, it was in this case. I tested this tweak out with the 'relxill' v2.3 model and was able to get it to build on Conda CIAO 4.17b1 by omitting "XSModel" from the list of libraries expected by the script.

DougBurke commented 2 months ago

So, we either start a 4.17 branch now or write this in a way that can be used with both 4.16 and 4.17 code. Hmmm.

nplee commented 2 months ago

I've just pushed a change to check CIAO version to handle this and avoid needing a new branch.