search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

MaskedIMAGECrate: add check for column ranges in addition to subspace/region #889

Closed kglotfelty closed 1 month ago

kglotfelty commented 1 month ago

This update adds a check for the range_min and range_max on the axes. This matches a recent-ish change to the C dmimgio routines that also now check the axes ranges. Without it, there were cases where the top most and right most pixels at the image edge would be inside the subspace, but the center of the pixel would be outside the range. Ie a partial pixel.

We need this range change to bring the python code in sync w/ the C code so they agree on which pixels are valid.

kglotfelty commented 1 month ago

Humm ... this didn't merge correctly. It only got the 2nd commit e95c09 . The first commit 387f9a9 is missing.

I'll make a new PR to try to pick up the change.

kglotfelty commented 1 month ago

nevermind; driver error.