search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

merge_obs & friends: drop use of dmcopy opt="all" due to GTI bug #893

Closed kglotfelty closed 1 month ago

kglotfelty commented 1 month ago

This closes #758

DougBurke commented 1 month ago

I have to admit to not remembering why I added these (or some of these) in the first place, but I am pretty sure that some of them were needed, back in the day. I am pretty sure that it then became a defensive posture (e.g. "better do this just in case"), so some cargo-culting was likely involved.

kglotfelty commented 1 month ago

the find_output_griddefinitely isn't needed since it's just a temp file used to seed skyfov.

The other two places will copy the REGION extension via dmappend. For the reproject_obs and merge_obs thread this really shouldn't happen because the physical WCS in the REGION extension will no longer match that in the event block; I'm not 100% sure this change hits that particular use case but I left it in there just in case. [Note: reproject_events doesn't copy all blocks so there's a bit of a disconnect between the no-reproject and w/ reproject paths in the code.]