search

cxcsds / ciao-contrib

Extra scripts and code to enhance the capabilities of CIAO.
GNU General Public License v3.0
8 stars 6 forks source link

Notebook plotter v1 2 #922

Closed dprincipe2 closed 2 days ago

dprincipe2 commented 1 week ago

Updated a lot of the tutorial text in notebook_plotter_tutorial.ipynb to be more user friendly and act more as standalone document describing the notebook_plotter tool. Added a new line to notebook_plotter.py to make reading the function help text easier.

dprincipe2 commented 2 days ago

Hi @DougBurke and @kglotfelty,

I'd really like this to be included for the release of CIAO 4.17. Please let me know if there is any issue with that.

DougBurke commented 2 days ago

@dprincipe2 - I've rebased this to avoid the merge and then tweaked some of the cells to take advantage of Sherpa a bit more

a)

Rather than

group_counts(...)
notice()
ignore(0, 0.5)
ignore(8, )

we filter then group, which makes the "low filter check" a bit better:

notice()
ignore(hi=0.5)
ignore(lo=8)
group_counts(...)

When this is for dataset 2 the notice and ignore calls are changed to notice_id and ignore_id

b)

Rather than

plot_xxx(...)
plt.yscale('log')

say

plot_xxx(..., ylog=True)

Do these changes look okay?

dprincipe2 commented 2 days ago

@DougBurke I think your suggested changes are good. If you have any other suggestions I'm happy to hear them. Thanks for taking a closer look at the tutorial!