mkfs.famfs fails silently if the Dax device has a superblock from another host on it

cxl-micron-reskit / famfs

This is the user space repo for famfs, the fabric-attached memory file system

Apache License 2.0

34 stars 9 forks source link

mkfs.famfs fails silently if the Dax device has a superblock from another host on it #9

Closed jagalactic closed 7 months ago

jagalactic commented 8 months ago

Exit code is 1, but no message. There should be a message.

Killing the superblock also only works on the host that created it. I can see going either way on this, but it at least seems reasonable. Should there be a double-secret force?

jagalactic commented 7 months ago

We changed the behavior so that "mkfs.famfs -fk " always kills the superblock. This is in part because of the recently merged PR that changes how we get the system uuid. We might revert that behavior after all users are running the new system uuid method. And we might add a super-secret kill-superblock method that can kill a superblock created by another node.

Input welcome...

jagalactic commented 7 months ago

We changed this behavior...