cxong / cdogs-sdl

Classic overhead run-and-gun game
https://cxong.github.io/cdogs-sdl/
GNU General Public License v2.0
895 stars 115 forks source link

Update some licenses #794

Closed reinerh closed 1 year ago

reinerh commented 1 year ago

Hi @cxong,

I'm a Debian maintainer and intend to package cdogs-sdl for Debian. I'm currently reviewing licenses of data files and found some inconsistencies/updates (many files documented as CC-BY-3.0 are (meanwhile?) CC-BY-4.0).

Also it looks like flamer_pickup.txt actually describes the file flamer_switch.ogg (as no flamer_pickup.ogg exists, and flamer_switch.ogg misses a .txt file; and from listening to the files I think the rename is correct).

explosion_small.txt says that it is derived from Explosion_001.mp3, which is (now?) licensed as CC-BY-NC-4.0. Is it possible to replace this file, as this license is too restrictive?

sounds/hits/gas/ is missing license information. Can you please add one?

sounds/package_r.txt is lacking some information. Did you create this sound file?

I noticed src/tests/*.c have no copyright headers. I assume they are licensed as BSD-2-Clause like your other code (as they have been commited by you)?

The following files are no longer available at their original location: http://freesound.org/people/superfreq/sounds/191583/ http://freesound.org/people/MentalSanityOff/sounds/153557/ https://www.freesound.org/people/thecluegeek/sounds/141364/ (So I'll just use the license info that is in the file)

Thanks for your response. I might have more questions and updates in the following days/weeks.

reinerh commented 1 year ago

I just found out that src/cdogs/cwolfmap/mame/fmopl.* is (re-)licensed under GPL-2+. https://github.com/mamedev/mame/commit/ec5b9deadee9a2f95e0691f7246a8f4663ba3ba9 Though I guess at the time the file was imported by the wolf3d project (can you please clarify where cwolfmap/ is coming from) it was still under the old MAME license.

cxong commented 1 year ago

The mame sources were taken from ecwolf which still had the mame license. I can try updating it to the latest version from mame but if there are code changes, I'll need to test first

reinerh commented 1 year ago

Thanks for the updates. No need to update the mame sources, it's fine like it is. :-)