cxw42 / TabFern

Google Chrome extension for saving and restoring sets of tabs, and for switching between windows and tabs from a vertical, grouped list.
https://cxw42.github.io/TabFern/
Other
170 stars 29 forks source link

Spin/hang after changing some settings #240

Closed gojomo closed 3 years ago

gojomo commented 3 years ago

Was delighted to discover/try TabFern after growing concern with the orphaned/unmaintained status of TabsOutliner.

Loaded into Brave, started poking around. After going to extension settings, I toggled a few options – IIRC, something about open-windows-to-top, and the 'skinny' scrollbars option. Went to reload TabFern window to see results (using menu 'View -< Reload this page", since F5 did nothing) - and the TabFern window hung with its 'loading' animation, never fully refreshing, along with the tab where its settings were displayed.

After a minute+, killed process in 'Task Manager' & tried restarting Brave. Hang in TabFern window recurred.

Killed process, removed TabFern, restarted Brave, re-installed TabFern - Hang in TabFern window recurred.

I suspect it's just a malfunction of one of the non-default options I set that's lingering - so, what's the best way to clear any residual non-default settings for a fresh-as-new re-install?

Thanks!

cxw42 commented 3 years ago

Thanks for reporting, and for the kind words! I haven't tried TF on Brave. Unfortunately, the easiest way to start fresh is to remove the extension and then re-add it. On the plus side, TF by design backs up to disk, so you can uninstall any time without losing your information (at least as of the most recent backup).

If you are able to figure out which setting it is, would you please let me know? That would certainly be worth fixing! Thanks!

gojomo commented 3 years ago

I did remove & re-add - and the problem recurred. So I think it's caching my settings changes. (Or, something else in its persistent state was the culprit.) Any idea where that any/all of that caching for TabFern is stored?

(Totally separately: another cool get-control-of-tabs project recently on my radar is 'TabFS' - https://github.com/osnr/TabFS. Ultimately my hope is a workflow that clusters related tabs by site or topic, allows searching them by age/fuzzy-topic, & can auto-close/index unread tags for ambient resurfacing later when pursuing the same topics.)

cxw42 commented 3 years ago

That is odd! It recurred after you re-added, but without your changing the settings again? Were you able to figure out exactly which settings? Thanks! Edit By the way, what exact OS and Brave versions?

Settings and tabs are both stored in the Chrome localStorage. If you want to clear them manually, in TF, hit F12 for the developer console and then: image Right-click the settings and hit Delete. (Please note that I have not tested this :) .)

I'm happy to receive feature requests, or feel free to upvote already-open issues you find that you would be interested in.

cxw42 commented 3 years ago

Just tried skinny scrollbars with the latest dev version (e7dfd6d) and was not able to reproduce. I did get an error message that I haven't seen before:

image

That is fixed in new commit 219dfc4. Et voila:

image

Are you able to try loading the latest unpacked? If not, this change will be in the next release, coming in the next few weeks if all goes well.

Brave version:

Brave   1.18.78 Chromium: 87.0.4280.141 (Official Build) (64-bit)
Revision    9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS  Linux
JavaScript  V8 8.7.220.31
gojomo commented 3 years ago

First 5 rows of about:version:

Brave | 1.18.78 Chromium: 87.0.4280.141 (Official Build) (x86_64)
-- | --
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS | macOS Version 10.15.7 (Build 19H2)
JavaScript | V8 8.7.220.31
Flash | (Disabled)
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36

When I uninstall then re-install TabFern, this window pops up but then doesn't refresh for minutes, (including a popup of the "tab unresponsive - wait, kill?" dialog) which is what I had assumed was an endless spin: image

However, while composing this post as it spun, if finally did briefly show another error (something about "installation not complete, 12/13, tabs won't be saved"), then finally refreshed again with actual content and no error! So it seems likely that what I've seen is just extreme slowness (upon 1st enablement or window-open?) rather than permanent hang.

But also: I'm not seeing the Fern icon to the right of the address-bar, though other extensions' icons appear there fine. And thus after (just now) closing the TabFern window, I'm unsure how to open it again short of exiting & re-launching the browser.

I'll keep poking around to see if I can narrow when the 'long unrefreshed spin' is triggered, & update with anything I notice.

cxw42 commented 3 years ago

Wow --- that is weird! Yes, please keep me posted.

I tried the Web Store version (0.2.1) and was not able to reproduce.

image

gojomo commented 3 years ago

At this point, I'm not sure this wasn't just TabFern being really, really slow in some open/refresh/restart operations - because it hasn't recurred, but an operation like closing the last tab of a window – either in TabFern, or outside – causes it to busy-spin for ten seconds or more, sometimes popping the 'unresponsive - kill tab?' dialog. This might be unique to use in Brave, or with my humongous count of open tabs.

cxw42 commented 3 years ago

Having heard nothing more, I'm going to close this for now. Feel free to reopen if you have more information!

gojomo commented 3 years ago

Related, but not quite the same thing, is that many operations are so slow they lead to a 10sec+ freeze of the TabFern window, and pop the "unresponsive - kill tab?" dialog-box. Most notably: closing the last tab of a window (from either TabFern or the tab itself), and the TabFern "move to top" right-click menu operation.

One of the main appeals of TabFern (like TabsOutliner before it) for me would be the ability to rapidly review & close older windows/tabs. So, these long pauses are a major impediment.

As I suspect you'd have more reports if this were common in Chrome, I have a hunch this may be a Brave-specific slowdown. If there's anything I can do to help profile the potential cause more, perhaps in a new more-focused issue, let me know.