search

cxw42 / TabFern

Google Chrome extension for saving and restoring sets of tabs, and for switching between windows and tabs from a vertical, grouped list.
https://cxw42.github.io/TabFern/
Other
170 stars 29 forks source link

Very slow on Brave w/ large number of windows/tabs #257

Open gojomo opened 3 years ago

gojomo commented 3 years ago

I have tons of open windows/tabs - hence the interest in TabFern. But in Brave, it's glacially slow, especially:

(1) On initial browser launch. Even if I had the TabFern window closed when quitting the browser, it wants to be open on launch. And it takes tens-of-minutes to populate, appearing as some form of this until it does:

image

(2) Any time a window is closed, either as a whole or when its last tab is closed, either via the native browser controls or the TabFern option. It seems like some refresh of the TabFern view goes into a very slow/busy spin - a smaller version of the view's initial contruction – whenver a window is removed. As a result, the window is unresponsive for tens-of-seconds (also saturating a CPU core). These big lags destroy the ability to use TabFern to quickly discard large nubmers of older tabs/windows.

I suspect this is a Brave-specific issue, or you'd have had more reports from people with lots of tabs in Chrome. If there's a way to sample (or interrupt) what it's spinning on, to finger likely culprits in the code/layout/etc, I'd be happy to run more tests. I suspect #205 is a roundabout attempt at dealing with a similar or related slowdown - thinking the slowness inherent, the workaround must be doing things incrementally, whereas I'd hope the slowdown could be identified & eliminated entirely.

cxw42 commented 3 years ago

Thanks very much for reporting! I do think this is Brave-specific. Do you have any experience with the Chrome/Brave developer tools? Select TF, hit F12, then the Performance tab can measure activities and tell us what's taking the time. Please let me know either way. Thank you, and thanks for using TF!

gojomo commented 3 years ago

Thanks very much for reporting! I do think this is Brave-specific. Do you have any experience with the Chrome/Brave developer tools? Select TF, hit F12, then the Performance tab can measure activities and tell us what's taking the time. Please let me know either way. Thank you, and thanks for using TF!

I do; what specifically should I log or look for, in which tab?

Upon bringing up DevTools on the TabFern window, then closing the last tab of a window from the TabFern 'X' option, the console added another 1000+ 'issues' in the Console/Issues tab: image

cxw42 commented 3 years ago

o_O that is crazy! The console messages alone could be contributing to the slowdown, and I don't control those.

Perf analysis: https://developer.chrome.com/docs/devtools/evaluate-performance/ is a walkthrough. I would like to see the flame chart view for a time when TF is very slow. Hopefully, we'll see whether the slowdown is in the browser, the jstree component that is the main UI, or somewhere else.

Thanks for your help with this! I am also happy to meet with you on Gitter or Zoom if you'd like to do some live analysis.

BTW, what OS, witness, and version, what Brave version, and what graphics card and driver version? I'd like to see if I can reproduce the issue. Much appreciated!