search

cy99 / shedskin

Automatically exported from code.google.com/p/shedskin
0 stars 0 forks source link

Makefile changes for different targets #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1. The flags -O2 and -fomit-frame-pointer shouldn't be included in the
"debug" target, as they conflict with debugging output.

2. (This is probably a Windows issue.) "make clean" currently removes
test.exe_debug and test.exe_prof, which should be test_debug.exe and
test_prof.exe respectively.

Original issue reported on code.google.com by fet...@gmail.com on 9 May 2010 at 1:05

GoogleCodeExporter commented 9 years ago 
Actually, -fomit-frame-pointer conflicts with the -pg option, not with -g...

Original comment by fet...@gmail.com on 11 May 2010 at 5:59

GoogleCodeExporter commented 9 years ago 
thanks! I fixed the 'make clean' problem: 

http://code.google.com/p/shedskin/source/detail?r=1465

I'm not sure it would be very elegant to have shedskin filter out
'-fomit-frame-pointer'.. do you have a better idea how to approach this?

Original comment by mark.duf...@gmail.com on 15 May 2010 at 5:03

GoogleCodeExporter commented 9 years ago 
I don't get what you mean by "filter out", but I was under the impression that 
you
could specify a different set of flags for different targets in a makefile (I've
never really worked a lot with makefiles, so I don't know exactly how).

I don't really mind leaving O2 in debug, but seeing as -fomit-frame-pointer
completely stops compilation (at least in my version of mingw gcc), I think it's
worth the trouble.

Original comment by fet...@gmail.com on 15 May 2010 at 9:19

GoogleCodeExporter commented 9 years ago 
yeah, it's possible to specify different flags, but where to get them? :) 
currently
they come from a single line in the FLAGS file. we could add several (optional) 
lines
here, or have shedskin look inside the single line and filter out
'-fomit-frame-pointer'. but it feels like it's not worth the effort if one can 
just
leave out '-fomit-frame-pointer' from FLAGS.. (it's not in there by default.. 
:-)).
what do you think?

Original comment by mark.duf...@gmail.com on 16 May 2010 at 4:18

GoogleCodeExporter commented 9 years ago 
Well, if one can just leave out -fomit-frame-pointer, then I guess that's all 
right.
But it was there by default until May 12, while I reported this issue on May 
8...

Original comment by fet...@gmail.com on 16 May 2010 at 10:59

GoogleCodeExporter commented 9 years ago 
ah, sorry, I sometimes commit FLAGS by accident.... is it alright if I close 
this
issue after putting FLAGS in .svnignore..? :) thanks again!

Original comment by mark.duf...@gmail.com on 17 May 2010 at 9:26

GoogleCodeExporter commented 9 years ago 
If it wasn't already clear from my last response, I have no problems with 
that...

Original comment by fet...@gmail.com on 18 May 2010 at 1:23

GoogleCodeExporter commented 9 years ago 
okay, thanks again for reporting! closing..

Original comment by mark.duf...@gmail.com on 18 May 2010 at 7:46