cyanfish / grpc-dotnet-namedpipes

Named pipe transport for gRPC in C#/.NET
Apache License 2.0
190 stars 48 forks source link

Support .NET 5.0 pipe security. #14

Closed ccruden-shookiot closed 4 years ago

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ccruden-shookiot commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ccruden-shookiot commented 4 years ago

Seems to be building and testing mostly properly at this point.... Failing CancelServerStreaming in the GitHub build, but the comment in code seems to indicate that test is flaky, and it doesn't fail when I run it locally...

cyanfish commented 4 years ago

Also ignore the test error around .NET core not being available, that's a preexisting issue that must've been caused by a change to the github CI environment.