Try setting the result / canceling / exception instead of direct set.

cyanfish / grpc-dotnet-namedpipes

Named pipe transport for gRPC in C#/.NET

Apache License 2.0

190 stars 48 forks source link

Try setting the result / canceling / exception instead of direct set. #22

Closed ccruden-shookiot closed 3 years ago

ccruden-shookiot commented 3 years ago

I wasn't sure about adding a lock {} around the cancellation call, and in any case it seems to protect members that the cancellation call doesn't need to. Definitely need Try... in all cases though depending on whether the cancellation gets called and then completion or vice versa.

ccruden-aspire commented 3 years ago

This is WRT this issue BTW, since I don't seem to be able to set the linked issue. https://github.com/cyanfish/grpc-dotnet-namedpipes/issues/20

ccruden-shookiot commented 3 years ago

FWIW, this change does seem to have addressed the linked issue. It would be nice to get it into a nuget.org distributed build instead of having to include our custom build in our distribution....

cyanfish commented 3 years ago

Fixed in https://github.com/cyanfish/grpc-dotnet-namedpipes/commit/51126a7a655e459696a67edb15a493601f7856b6 and published as version 1.4.0.