search

cyanfish / grpc-dotnet-namedpipes

Named pipe transport for gRPC in C#/.NET
Apache License 2.0
190 stars 48 forks source link

Ensure trailers are added to calls that throw #45

Closed alexhelms closed 9 months ago

alexhelms commented 1 year ago

I was adding C# exception details to trailers and throwing an RpcException in the service handler and discovered that the trailers were not being included in the RpcExpection that was thrown by the client's call. The trailers are included in the payload over the named pipe but were missing in the exception.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cyanfish commented 1 year ago

Hi, thanks for the PR! For the CLA check, it looks like you signed it with your Github email but the email used for the commits is different - could you either add that email to the CLA or change the email on the commits?

alexhelms commented 1 year ago

This fix was found for work so that's why it has my work email attached to the commit. I'm trying to find the right person to be able to sign the CLA. Hopefully I can get that resolved soon!

cyanfish commented 9 months ago

Fixed in e485a5d4bede688d3e490c466a1f5d6e6925b4c5