cyanfish / naps2

Scan documents to PDF and more, as simply as possible.
https://www.naps2.com
Other
2.74k stars 321 forks source link

"About" window appearing when pressing F1 though not assigned in appsettings.xml #280

Closed chyron8472 closed 8 months ago

chyron8472 commented 8 months ago

Describe the bug After reassigning F1 to a <ScanProfile> and NOT to<About>, About window still appears when pressing F1 unless a Scan Profile is otherwise called.

To Reproduce Steps to reproduce the behavior:

  1. Set <About>Ctrl+F1</About> in appsettings.xml (or as any other hotkey, or leave it blank.)
  2. Set <ScanProfile1>F1</ScanProfile1> in appsettings.xml
  3. Open NAPS2.
  4. Press F1. 4a. BUG: Observe "About" window open
  5. Click Scan dropdown
  6. While dropdown is open, press F1. 6a. Observe Scan Profile 1 being called.

-- Note: Scan Profile 1 does list F1 as its hotkey in the Scan dropdown menu. -- If Scan dropdown menu is clicked and then closed, F1 still calls About window. -- If Scan dropdown menu is clicked and F1 is pressed while menu remains visible, then F1 correctly calls Scan Profile 1 and not About window. -- If scan is attempted (by means other than pressing F1), pressing F1 afterward correctly calls Scan Profile 1 and not About window.

Expected behavior Setting <ScanProfile1>F1</ScanProfile1> and <About>Ctrl+F1</About> in appsettings.xml should always call Scan Profile 1 when F1 is pressed.

Desktop (please complete the following information):

psp-oscar commented 8 months ago

Possible another related issue, the main menu/ribbon items "About" & "Settings" disappeared from Version 7.3.0.0 (7.2.2.0 was ok) in case naps2 interface is set to any language except English (and some others). OS: xUbuntu 18.04 & 22.04 deb.

cyanfish commented 8 months ago

@psp-oscar Feel free to create another issue, but you should be able to just make the window a bit wider for it to show up.

cyanfish commented 8 months ago

This should be fixed in 7.3.1.