cyanharlow / solitaire

Solitaire.
http://diana-adrianne.com/solitaire/
107 stars 27 forks source link

Number went away #1

Open MtnBiker opened 4 years ago

MtnBiker commented 4 years ago
image

Also the black cards are grey which is a bit confusing. But then I havent' played Solitaire for several years. And don't play any games on computers these days. I never was a gamer.

If that's a dark/light mode toggle. It doesn't work either.

macOS Catalina. Chrome. For the first screen shot

Safari works better, the toggle works. Didn't play long enough to know about the number error which occurred at or shortly before the 33 step.

Fun and congratulations on doing this.

MtnBiker commented 4 years ago

Forgot the Safari screenshot.

image

And should have said the numbers went away on the stacks at the top

cyanharlow commented 4 years ago

@MtnBiker Hm - interesting - I'm also on catalina chrome and not able to replicate this.

However - the theme colors and game progress are saved in cookies - is there any chance you have all cookies blocked by default?

MtnBiker commented 4 years ago
image

And unlikely I'd block them from my own computer, but it could happen since I fiddle with those setting from time to time.

Don't fix it for me though. If I play solitaire it's more like likely on iOS.

MtnBiker commented 4 years ago

To be sure I tried again

image
cyanharlow commented 4 years ago

@MtnBiker i just updated it to fail safelly to a default theme choice - as it seems like it's not loading either dark or light mode which would explain the poor UI. Please let me know if it helps 👍

If not - do you have any console errors? Or can you let me know the document.cookie value stored?

MtnBiker commented 4 years ago

Nice hint on console errors. I was just running it by opening the index.html in Chrome or Safari. Once I ran it from python server (whatever it's called?, I have it set to an allias), the modes work. I imagine the rest will work now. One minor UI issue. In the screen shot the left hand spot is available for a king, but it would be easy to miss that.

image

PS. This is the previous version I'm using in Safari PPS. Missed the "hidden" Edit

MtnBiker commented 4 years ago

PS. This is the previous version I'm using.

cyanharlow commented 4 years ago

@MtnBiker just added an "empty" state for the stack so that should be harder to miss now: Screen Shot 2020-06-18 at 9 52 27 AM