cyanreg / cyanrip

Bule-ish CD ripper
GNU Lesser General Public License v2.1
232 stars 10 forks source link

Add (lib)fdk-aac support? #37

Closed diizzyy closed 1 year ago

diizzyy commented 1 year ago

Unless I'm reading the code incorrectly it doesn't seem to support this library at all via ffmpeg, as it is superior it would be nice if it would be an option and/or possible default one.

wiiaboo commented 1 year ago

If you disable the built-in aac encoder and only include fdk-aac when compiling ffmpeg, I think -o aac will use it, but not sure.

diizzyy commented 1 year ago

I guess that works but it's a bit inconvenient.

cyanreg commented 1 year ago

Closing this. I am rewriting ffmpeg's aac encoder anyway.