search

cyanreg / cyanrip

Bule-ish CD ripper
GNU Lesser General Public License v2.1
227 stars 10 forks source link

Don't embed cover #52

Closed Daniel6372 closed 1 year ago

Daniel6372 commented 1 year ago

cyanrip by default both downloads the cover to the output directory and embeds it in every each flac file. A lot of covers are upwards of several MB in size and this can result in a significant total size increase (e.g. 3 MB size cover for 15 tracks will result in 45 MB additional size, which could make up 10-15% of the total size).

There should probably be an option to select between embedding cover, only downloading to a file and not downloading cover at all.

cyanreg commented 1 year ago

I'm running out of command line switches, do you REALLY need to save a few megabytes on a rip hundreds of megabytes?

Daniel6372 commented 1 year ago

Personally I'd edit the tags after ripping anyway, but it would be a better default not to embed. It's a total waste of space and covers can be embedded manually by those who wish to. This is why an option would be ideal.

cyanreg commented 1 year ago

I may add an option, but I'm not making it a default. The whole point is not to edit any tags at all after ripping.

cyanreg commented 1 year ago

@Daniel6372 Added -G in d457cd5ae181931e4c6b86979ae7a1ab174004ab

Daniel6372 commented 1 year ago

Thank you for adding the option!