search

cyanreg / cyanrip

Bule-ish CD ripper
GNU Lesser General Public License v2.1
227 stars 10 forks source link

Add an option to specify the image size for cover lookup #83

Closed s-k2 closed 6 months ago

s-k2 commented 6 months ago

Some images of coverarchive.org are really huge. Personally I'm quite comfortable with smaller images. Thus I added an option to specify the desired size for cover lookup.

It would be nice, if you could merge that pull-request. If you aren't comfortable with the way I implemented that, feel free to ask me for modifications.

A great tool, btw. An easy to use CLI, a single C program with just a handful of dependencies. But it does all the daunting tasks to read out CDs and tag it nice for my music library. Thank you for that work!

cyanreg commented 6 months ago

Could you decapitalize the names of the cover art string arrays? Also make COVERART_LOOKUP_SIZE_ORIGINAL = 0 (leave the rest as-is). Finally, align each switch: of case() with the indentation of the case(). In the future it would be a good idea to download separate versions for embedding and Front.jpg written during ripping.

s-k2 commented 6 months ago

Ouch, I should look more closely on the existing code-style and not stick with my own...

Indeed, separate sizes would be much better

cyanreg commented 6 months ago

It's fine, thanks a lot for the patch.