cyaoxuan / pe

0 stars 0 forks source link

Unable to edit job application deadline for some applications #6

Open cyaoxuan opened 1 year ago

cyaoxuan commented 1 year ago

Tried running the command edit --application 1 --by 10-10-2023 with valid data as seen below, but I get the error that "Job Application with same name found. Set a different name" when the name was not set. For context, I am using the sample data with 1 job application added. I am unsure of what the issue is and how to rectify this issue as a user. This also applies when I edit index 2.

image.png

However, edit --application 3 --by 10-10-2023 with the same data as above works

image.png

nus-pe-script commented 12 months ago

Team's Response

Unfortunately I am not able to reproduce this bug after multiple tries.

Based on how I am not able to reproduce the bug, I would assume that this is a rare case.

Based on my understanding of how Jobby works, I would assume that the way for the user to resolve this is to close and open the application. This would be a bit of an inconvenience but not a major one, although this was not documented as we did not expect such a bug to occur.

Regards, I will put medium since it appears to be a legitimate bug that occurs rarely, but I cannot reproduce it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: I tried it again and realised that my previous step of editing the organisation was also relevant to this bug. I apologise for not making it clear previously due to the lack of time. That being said, I hope this does not affect the dev's accuracy marks.

Steps to reproduce:

I believe this is due to some kind of mismanagement of the link between the organisation and job application as it is only reproducible when the organisation has been edited. Additionally, there seems to be some issue with the checking of duplicate job applications, hence it is ok to edit by title though it gives rise to an extra job application (might be an outcome of this bug or a separate issue all together, so probably not highly relevant to this bug report).


## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** As explained in the corrected steps to reproduce, it does not seem very unlikely for such a case to happen as it only requires the editing of the organisation followed by editing the job application. A realistic case I can think of where a user would need to do it is if the point of contact changes between different stages of the interview process (e.g. HR team transfers to the SWE team between the resume and interview process), which would require changes in both the organisation and job application entities. While it is true that this issue will be resolved when I close and reopen the app, it did not occur to me as a user due to my lack of understanding of the app, though a user would eventually try that anyways. Nonetheless, I think this bug surfaces a high severity flaw in the application while it is running, specifically regarding the mismanagement of the link between the organisation and job application, a key aspect of the Jobby application.