search

cyb3rko / flashdim

Modern flashlight app with dim functionality on Android 13+
Apache License 2.0
456 stars 18 forks source link

GSI ROM Support #61

Open rabaimorp opened 7 months ago

rabaimorp commented 7 months ago

The problem:

On my samsung galaxy a53 on stock rom this app was working without problem with 5 dim levels. Than I decided to flash a GSI (specifically Lineage OS 21). This obviously changed my device's properties, causing the app to not recognise my device. If I change back the device identifiers using a root shell, or editing the build.prop this isnt the case, but that causes a bunch of other issues on my device, since I'm not using stock rom, but still having the same values.

My idea for a possible solution:

If it was possible to manually define the device within the app. (or loading a stock build.prop file from internal storage)

Or an even simpler solution: an option in the app that would automatically identify the device, even on gsi roms by looking at /vendor/build.prop (since almost all people on custom gsi roms have root anyway).

cyb3rko commented 6 months ago

Thanks for the input.
Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

rabaimorp commented 5 months ago

Thanks for the input. Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

Not necessarly. But not just for my rootless soulution idea. For testing I can recommend emulating android using Waydroid (that you can root by super easily), since testing the flashlight might not be neceassry if we only talk about custom device detection

rabaimorp commented 5 months ago

Thanks for the input. Sounds interesting, but to develop something like your proposed solution I would need to have a rooted device.

Maybe I will root one of my older Samsung phones at some point

Not necessarly. But not just for my rootless soulution idea. For testing I can recommend emulating android using Waydroid (that you can root by super easily), since testing the flashlight might not be neceassry if we only talk about custom device detection

cyb3rko commented 5 months ago

I've read something about Waydroid a few days ago, I will try that out when I find time for this :)