search

cyb3rko / pazzword

The most intelligent password evaluator app
Apache License 2.0
54 stars 2 forks source link

Custom password generator + Alphaspace Type #5

Closed benni347 closed 1 year ago

benni347 commented 1 year ago

Hello,

With this pull request I implement a password generator so, new types can be added more easily. The main focus for this was to fix #3. This pull request also contains the code to fix that issue.

cyb3rko commented 1 year ago

Hi Benni, thanks for your contribution. I will soon take a look at it.

I tend to replacing the input field for Password types with checkboxes of what to include into the password. Then we would not need hardcoded types like Alphanumeric and Alphaspace.

Just like what Bitwarden does:

cyb3rko commented 1 year ago

But I'll first merge your PR and include it seperately I think.

benni347 commented 1 year ago

Do you want to implement check boxes only for the passwords or also for the passphrase?

cyb3rko commented 1 year ago

There are no settings for the passphrase generation except the length. So check boxes would not really make sense there.

benni347 commented 1 year ago

There are settings for passphrases in the linux desktop client for bitwarden. 20230423_16h43m59s_grim

cyb3rko commented 1 year ago

Yeah, but Pazzword uses the nbvcxz passphrase generator, which does not support those settings.