cyb3rko / pincredible

Modern and secure Android app to help you remember any PIN
Apache License 2.0
77 stars 5 forks source link

Improve save dialog #18

Closed johnjohndoe closed 1 year ago

johnjohndoe commented 1 year ago

I noticed the following issues:

cyb3rko commented 1 year ago

Thank you for your feedback.

Which save dialog are you referring to? The password input dialog for backups or the dialog when saving the PIN table as image?

johnjohndoe commented 1 year ago

I was referring to the "Save PIN" dialog but it is probably good to check all dialogs.

cyb3rko commented 1 year ago

Which version did you use?

Because for me it works as expected and as defined by Material 3 (using Version 0.4.1):

When typing and exceeding the limit the box and character limit color turns red.

If I click on "Save" an additional error message is shown.
johnjohndoe commented 1 year ago

Ah. My expectation would be that characters more than 30 are not accepted and the error shows up immediately when I type 30+ characters.