cyb3rko / pincredible

Modern and secure Android app to help you remember any PIN
Apache License 2.0
77 stars 5 forks source link

F-Droid can't build #25

Closed licaon-kter closed 1 year ago

licaon-kter commented 1 year ago

ref: https://github.com/cyb3rko/pincredible/blob/v0.5.0/settings.gradle#L19

ref: https://monitor.f-droid.org/builds/log/com.cyb3rko.pincredible/8#site-footer

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/fc7ec138faaccb1df9a18e09c1cbbbc05902e30a

cyb3rko commented 1 year ago

Thanks for the report, haven't recognized it yet.
I see the problem:

licaon-kter commented 1 year ago

the F-Droid build does not have this custom logic to rely on the remote library repo, any way to include this into the build?

The remote is ../somepath/ ? How does that work out for you exactly when you clone this project in a random folder?

Wanna use that? Use a submodule: https://git-scm.com/book/en/v2/Git-Tools-Submodules :)

cyb3rko commented 1 year ago

Atm it works by cloning the library in the same parent folder... Yeah, a bit of a workaround, but I just wanted it to work for now as I had no time to investigate further how to do that properly.

Maybe it's time now to take a look at submodules, good call. Would that would well with the F-Droid build then?

licaon-kter commented 1 year ago

Yes, as the submodules will get cloned too, then you can reference them at will.

cyb3rko commented 1 year ago

@licaon-kter I have included the submodule now and adapted the build scripts for the release apk output. It seems to work on my site now, let's see if that works on your side (F-Droid build) as well.

licaon-kter commented 1 year ago

https://gitlab.com/fdroid/fdroiddata/-/commit/b789edbb6ff92f40b54f8915390907261497f994