cyb3rko / pincredible

Modern and secure Android app to help you remember any PIN
Apache License 2.0
77 stars 5 forks source link

Meta: Casual topic `refac` vs `rfct` #27

Closed goyalyashpal closed 10 months ago

goyalyashpal commented 11 months ago

Hi!

kudos for adhering to conventional commits since v0.5. ur changelogs look awesome

One extremely small thing i thought to bring in your notice is that:

while trying to think of different combinations of omissions, i stumbled upon the obvious one: refac

ecosia search: refac commit | duckduckgo search: refac commit

ecosia ddg

So what?

umh, nothing much... it's entirely upto you. as i said, i just wanted to discuss this with you - not necessarily aimed at any particular outcome...

it it makes sense to you, then you may choose to use refac in future; but downside to it can be that if doing anything programmatic using commit messages from these past rfct ones - u'll have to consider for both rfct and refac which might be error prone.

but this use-case can be a corner case in and on itself...

what are your thoughts on this?? 😃

goyalyashpal commented 11 months ago

you can close this after reading 😃

goyalyashpal commented 11 months ago

Also,

123 456 789 012
res tru ctu re
res tru ct
rew rit e

str uct

rst rct
rer yt
rst ct
str ct