search

cybardev / cutefetch

Tiny coloured fetch script with cute little animals
https://cutefetch.cybar.dev
GNU General Public License v3.0
44 stars 4 forks source link

resolution not available #5

Closed yogeshdnumb closed 1 year ago

yogeshdnumb commented 1 year ago

It was working fine some time ago but now I'm not able to get any output for xdpyinfo | grep 'dimensions' | grep -o '[0-9]+x[0-9]+' | head -n 1

I think some update to xdpyinfo changes the format of output so should I change the regex

yogeshdnumb commented 1 year ago

adding -E to the second grep command fixes the issue xdpyinfo | grep 'dimensions' | grep -oE '[0-9]+x[0-9]+' | head -n 1

cybardev commented 1 year ago

That is indeed my bad. I always alias grep to be grep -E on my systems, so I completely missed it.

Would you like to make a PR with the changes, or should I just update and push?

yogeshdnumb commented 1 year ago

Would you like to make a PR with the changes, or should I just update and push?

I'd love to give a PR and thanks for this awesome script

cybardev commented 1 year ago

Marvelous. It looks good; thanks for the work.

I'll test it out and merge when I get to my Linux machine.

thanks for this awesome script

You're welcome 😊 It fills me with great joy that other people are using it. Let me know if you see any other issues.