Domain joined status returns bad when the status is undetermined

[LargeGoose]

In reviewing a recent health check I saw that the HTML output of this contained "Vault step was completed with status 'Bad'. See more details -> Could not Vault was not joined to a Domain."

One would think that bad was the result you would get if it is or had been joined to a domain but that's not what happens. That would be only "Warning"

I would think that they should be the other way round, the warning is for when the test fails.

The text should also probably say "Could not determine if the Vault is or was joined to a Domain.

[AssafMiron]

Hi Angus,

Thanks for the update, I updated the error text To better understand the issue that you present, I will try to first explain the current process We check if the vault is domain joined or not (by searching in a Windows Log file) If it is domain joined, then the return is Warning If there was an error in reading the file (or any other error) the return is Bad If the Vault is not domain joined, the return is Good

Does this fit what you expected?

Thanks, Assaf

On Thu, Sep 30, 2021 at 4:51 PM Angus Herron @.***> wrote:

In reviewing a recent health check I saw that the HTML output of this contained "Vault step was completed with status 'Bad'. See more details -> Could not Vault was not joined to a Domain."

One would think that bad was the result you would get if it is or had been joined to a domain but that's not what happens. That would be only "Warning"

I would think that they should be the other way round, the warning is for when the test fails.

The text should also probably say "Could not determine if the Vault is or was joined to a Domain.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cyberark/CYBRHardeningCheck/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3PN3PPRSF3RJ6ACNYCCO3UERTNTANCNFSM5FCMSGVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[LargeGoose]

Hey Assaf,

            I guess my point is that I would have thought that a return of “bad” should be when the Vault is or has been domain joined and “warning” should be when it wasn’t clear (because of an error). A return of bad seems more serious than a warning?

Cheers,

Angus

From: Assaf Miron Sent: 04 October 2021 08:01 To: cyberark/CYBRHardeningCheck @.> Cc: Angus Herron @.>; Author @.***> Subject: Re: [cyberark/CYBRHardeningCheck] Domain joined status returns bad when the status is undetermined (#67)

Hi Angus,

Thanks for the update, I updated the error text To better understand the issue that you present, I will try to first explain the current process We check if the vault is domain joined or not (by searching in a Windows Log file) If it is domain joined, then the return is Warning If there was an error in reading the file (or any other error) the return is Bad If the Vault is not domain joined, the return is Good

Does this fit what you expected?

Thanks, Assaf

On Thu, Sep 30, 2021 at 4:51 PM Angus Herron @.***> wrote:

In reviewing a recent health check I saw that the HTML output of this contained "Vault step was completed with status 'Bad'. See more details -> Could not Vault was not joined to a Domain."

One would think that bad was the result you would get if it is or had been joined to a domain but that's not what happens. That would be only "Warning"

I would think that they should be the other way round, the warning is for when the test fails.

The text should also probably say "Could not determine if the Vault is or was joined to a Domain.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cyberark/CYBRHardeningCheck/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3PN3PPRSF3RJ6ACNYCCO3UERTNTANCNFSM5FCMSGVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because you authored the thread. Reply to this email directly, https://github.com/cyberark/CYBRHardeningCheck/issues/67#issuecomment-933199874 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/ACPORF3SH473XK3ZEA6657DUFFGJ3ANCNFSM5FCMSGVA unsubscribe. Triage notifications on the go with GitHub Mobile for https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 iOS or https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub Android.