search

cyberark / KubiScan

A tool to scan Kubernetes cluster for risky permissions
GNU General Public License v3.0
1.31k stars 130 forks source link

Remove warnings when TLS verificaition is turned off when using a token / no CA file #19

Closed jpts closed 2 years ago

jpts commented 4 years ago

This just moves the urllib3 warning suppression line to be enable automatically, when token auth is used. Should fix #5 . Tested with/without CA when using token. Have encountered no issues during my own testing.

g3rzi commented 4 years ago

Thanks :) I will check it first

g3rzi commented 4 years ago

I tested your changes but when I run the following: 

root@ubuntu:~/kubi/KubiScan# python3 KubiScan.py -ho 192.160.0.3:8443 -t token -rs

I am still getting the following errors in the beginning: 

/usr/local/lib/python3.5/dist-packages/urllib3/connectionpool.py:857: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecureRequestWarning)

How did you run it? Did you use docker or directly with python like I did?

g3rzi commented 4 years ago

?

g3rzi commented 2 years ago

We tested it on a new machine, it works fine. Thanks.

jpts commented 2 years ago

awesome, glad you got it working :tada:

g3rzi commented 2 years ago

Thank you for the contribution, and sorry it took time.