cyberark / Secret-Manager-formerly-AAM

Apache License 2.0
0 stars 6 forks source link

Script doesn't validate the accounts are not identical #1

Open szamir1 opened 3 years ago

szamir1 commented 3 years ago

Summary

You can enter the same account twice as the dual account in the command line (instead of 2 different accounts). For example, this command line will work and script finished with success: .\DualAccount-Creation.ps1 -PASUserName 'Admin' -PASPassword '123Password' -AccountList test1@1.1.1.1@123;test1@1.1.1.1@123

Steps to Reproduce

Steps to reproduce the behavior:

  1. Run the script with two accounts which are identical.
  2. Look at the console's logs and verify in PVWA if the accounts were created.

Expected Results

Script will validate the accounts configured are not identical, and will stop running with a relevant log message.

Actual Results (including error logs, if applicable)

The script finished with success. The account will be create once, and it will be attached to the group provided in the configuration file. The issue is that the account will be on the group without anyone else, so the dual account feature won't actually work, as the account doesn't have who to rotate with (Active <-> Inactive).

Reproducible

Version/Tag number

Any CP/Synchronizer version, PAS v12.1.