Consolidated changes to review

Pooja-Gangwar commented 2 years ago

Desired Outcome

Implement unit tests for conjur_variable plugin Implement test coverage reporting in CI Ansible Collection must be tested against Ansible Core 2.11 Add Quick Start for using Conjur Collection

Implemented Changes

Documentation in contributing file Unit tests cases in tests' unit folder Verified Ansible collection with Ansible latest version Test coverage reporting is generated via CI

Connected Issue/Story

Please find below Ticket/branch names , these tasks are completed . ONYX-15261 ONYX-15263 ONYX-15264 ONYX-17971

CyberArk internal issue link: [insert issue ID]()

Definition of Done

Implemented unit tests for conjur_variable plugin Implemented test coverage reporting in CI Tested Ansible Collection against Ansible Core 2.11 (latest) Document in contributing file that how the development environment can be easily used .

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[x] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[ ] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[x] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

shulifink commented 2 years ago

@itsbrugu - a couple of things:

When this is ready to start working on, please move Status to OPEN
Please give us the exact link of the content that we need to move into FLARE.
Please make sure that if there are any changes to this content after we start moving it into FLARE, we are updated immediately.
Please note: IMPORTANT! Once we have released this topic in the official docs (docs.cyberark.com), this page must be updated so that the reader has only basic information and a link to the official docs.

cc: @maciek01

shulifink commented 2 years ago

@maciek01 ; @ismarc - It seems Gillian is not a member of this organization. Can you add her?

john-odonnell commented 2 years ago

Closed in favor of:

cyberark / ansible-conjur-collection