What's changed? Why were these changes made?
When attempting to use the code in this repo against a CyberArk instance several issues were encountered. This PR attempts to correct the issues we experienced. All changes are to the cybrerark_user module:
-- Added a timeout to be passed through to the http calls.
-- Added a vault_user_id option to make users act like groups for API v2.
-- Added vault_id parameter to the module documentation.
-- Added construct_url method to handle the '/' between the base url and the endpoint.
-- Added resolve_username_to_id and resolve_group_name_to_id methods. These methods will take an older parameter (like group_name) and resolve that to an ID. These resolutions will only be used if the corresponding vault_id/vault_user_id options are not set. This change makes the module backwards compatible.
-- Fixed user_delete function (it was using API V2 expecting a user id with the old username parameter)
How should the reviewer approach this PR, especially if manual tests are required?
This PR was made with limited testing against a CyberArk instance, none of the tests in the tests folder were run. Please validate functionality.
Are there relevant screenshots you can add to the PR description?
What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76]
Did not open issues against the repo for these, please let me know if you want issues tied to this PR.
Checklists
Change log
[ ] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update
[X] There is no CHANGELOG in this repo
Test coverage
[ ] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests
[X] This PR may require unit test changes but I do not have a way to test them. Please review and let me know if you require anything from a testing perspective.
Documentation
[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation
[X] This PR does not change the README content. There is content in the docs directory that could change but I am unsure if that doc is current since the README references the Ansible website directly.
What does this PR do?
What's changed? Why were these changes made? When attempting to use the code in this repo against a CyberArk instance several issues were encountered. This PR attempts to correct the issues we experienced. All changes are to the cybrerark_user module: -- Added a timeout to be passed through to the http calls. -- Added a vault_user_id option to make users act like groups for API v2. -- Added vault_id parameter to the module documentation. -- Added construct_url method to handle the '/' between the base url and the endpoint. -- Added resolve_username_to_id and resolve_group_name_to_id methods. These methods will take an older parameter (like group_name) and resolve that to an ID. These resolutions will only be used if the corresponding vault_id/vault_user_id options are not set. This change makes the module backwards compatible. -- Fixed user_delete function (it was using API V2 expecting a user id with the old username parameter)
How should the reviewer approach this PR, especially if manual tests are required? This PR was made with limited testing against a CyberArk instance, none of the tests in the tests folder were run. Please validate functionality.
Are there relevant screenshots you can add to the PR description?
What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76] Did not open issues against the repo for these, please let me know if you want issues tied to this PR.
Checklists
Change log
Test coverage
Documentation
README
s) were updated in this PR, and/or there is a follow-on issue to update docs, or