Online Buildpack uses wrong golang version

cyberark / cloudfoundry-conjur-buildpack

Buildpack for the Conjur / Cloud Foundry integration

Apache License 2.0

0 stars 3 forks source link

Online Buildpack uses wrong golang version #39

Closed micahlee closed 5 years ago

micahlee commented 5 years ago

https://github.com/cyberark/cloudfoundry-conjur-buildpack/pull/38 updated the golang version for the buildpack to 1.12, including a non-backward compatible API change for obtaining the home directory.

The online buildpack, however, is still installing go 1.11.

It looks like this wasn't caught before because of a bug in the online buildpack integration test: https://github.com/cyberark/cloudfoundry-conjur-buildpack/blob/master/ci/features/integration.feature#L32

izgeri commented 5 years ago

@micahlee It would be good to update the guidelines for this in CONTRIBUTING.md - that's where I looked to find out where to update the go version, and this was missing there.