cyberark / cloudfoundry-conjur-buildpack

Buildpack for the Conjur / Cloud Foundry integration
Apache License 2.0
0 stars 3 forks source link

Undocumented hard requirement for language buildpack #83

Closed whip113 closed 4 years ago

whip113 commented 4 years ago

Summary

If you do not explicitly include the language build pack in your application manifest (because it's automatically included by PCF), the conjur build pack will not invoke. This hard requirement is not documented.

Steps to Reproduce

In you application's manifest.yml, only include the conjur build pack Stage your app Observe that the conjur build pack does not get invoked

Expected Results

Conjur build pack should be invoked

Actual Results (including error logs, if applicable)

Conjur build pack is not invoked

Reproducible

Version/Tag number

cf cli version 6.51 DAP 11.5 PCF 2.9 (?)

izgeri commented 4 years ago

@whip113 would you suggest that we just add a bolded Note to this section to say something like:

If you add the Conjur buildpack to your manifest or cf push command but don't also explicitly include the language buildpack, Cloud Foundry will see that the Conjur buildpack is not a "final buildpack" and will fail to invoke it. To use this buildpack, you must follow the instructions for using multiple buildpacks and specify both the Conjur buildpack and the final, language buildpack for your app (in that order).

whip113 commented 4 years ago

I think that would be perfect.

izgeri commented 4 years ago

Resolved in #84