search

cyberark / community

Information for the CyberArk contributor community
Apache License 2.0
7 stars 5 forks source link

Turn on master branch daily builds for all product repos we own #20

Closed izgeri closed 4 years ago

izgeri commented 4 years ago

Add daily build triggers to the Jenkinsfile for any repos in this list that have pipelines but don't already have it turned on:

Daily pipeline builds can be turned on by adding

triggers {
  cron(getDailyCronString())
}

to the Jenkinsfile

doodlesbykumbi commented 4 years ago

The repo listed below do not have a Jenkinsfile at all. Adding CI is out of scope of this issue. Separate issues are created in each repo for that.

conjurdemos/cloudfoundry-conjur-demo conjurinc/cloudfoundry-conjur-tile cyberark/go-mssqldb conjurinc/secretless-demo conjurinc/summon-keyring conjurinc/summon-conjurcli conjurinc/summon-chefapi

izgeri commented 4 years ago

@JakeQuilty can you please review the work that @doodlesbykumbi did here - and if it looks good to you that all repos on this list have master builds turned on or have an issue logged to add a pipeline (if appropriate), close this card? Thank you!!

JakeQuilty commented 4 years ago

I didn't see a Add CI Pipeline issue on these two repos: https://github.com/conjurinc/secretless-demo https://github.com/cyberark/go-mssqldb

izgeri commented 4 years ago

@doodlesbykumbi wdyt - I don't think we want a pipeline on secretless-demo, but should we add one to go-mssqldb?

doodlesbykumbi commented 4 years ago

Definitely want a CI Pipeline for go-mssqldb. It's a fork so adding issues to it right now isn't available. I wonder if this is the sort of project that could benefit from Github Actions, it's public.

izgeri commented 4 years ago

@doodlesbykumbi are github actions turned on for that project's unit tests now? If so, I think we can close this issue

doodlesbykumbi commented 4 years ago

@doodlesbykumbi I have a PR over at https://github.com/cyberark/go-mssqldb/pull/21 so I think this issue can be closed.