search

cyberark / community

Information for the CyberArk contributor community
Apache License 2.0
7 stars 5 forks source link

Add General Guidelines for Code Reviews (#5) #49

Closed BradleyBoutcher closed 4 years ago

BradleyBoutcher commented 4 years ago

Connected to #5

BradleyBoutcher commented 4 years ago

@izgeri I drafted this myself without borrowing from anywhere else. I think I was mistaken in the amount of involvement a contributor had. I intentionally wrote this from the perspective of someone leaving a review, as I was under the impression that an external contributor would be able to review code and leave comments, and approval-power could be given to high-level contributors.

We already have documentation in this same file that covers drafting commits and submitting a PR, which was written from the link you provided (#Working-on-Issues). This entire PR will need to be replaced with a section about 'what to expect when we review your code', which will be drastically shorter.