Closed DvirCyberArk closed 6 years ago
What's the sensitive information we're concerned about?
@DvirCyberArk: mind rebasing from the v5Support
branch? We really need to see tests running in Jenkins.
Thanks @DvirCyberArk for the updates. I'll get this merged.
What does this pull request do? Introducing Conjur policy entity to SDK and allow to call load policy to Conjur Server over REST
What background context can you provide? none
Where should the reviewer start? Maybe manual testing can be a good way to start this review process (uploading .yml file)
How should this be manually tested? Create policy yml file convert it to stream and load it using Client to Conjur EE - check UI if policy loaded correctly in structure and functionality.
Link to build in Jenkins (if appropriate) https://jenkins.conjur.net/view/Conjur%205.x/job/cyberark--conjur-api-dotnet/
Questions:
We have some issues with Policy size and timeout limit? Yes, those will be fixed in a separate PR since we want to align GitHub to our current status of code base.
Why are you ignoring policy response. Great question, for our usecase it can include sensitive information that we don't need/want but for open source maybe we need to change it. WDYF?
Are you supporting concurrency? No.