search

cyberark / conjur-api-dotnet

.NET client for the CyberArk Conjur API
Apache License 2.0
15 stars 11 forks source link

Fix id to name bug #28

Closed sashaCher closed 5 years ago

sashaCher commented 6 years ago

What does this pull request do? Fixing an id to name bug in list resources functionality. What background context can you provide? Both User and Variable ctors expect to receive a Name of a resource. List Variables and Users APIs returns a JSON with full Id of the resource: account:kind:name. We used this ID straight forward in order to create Variables and Users in corresponded list resources functions. It caused to those resources to be useless because they treated this full id as only a name. Where should the reviewer start? conjur-api/Resource.cs

dividedmind commented 5 years ago

Pulling in Linq just for this feels a bit heavy-handed. Is there a reason not to use String.Split instead?

alexkalish commented 5 years ago

Closing due to inactivity.