cyberark / conjur-api-java

Java client for the CyberArk Conjur API
Apache License 2.0
17 stars 14 forks source link

Enable to set custom SSLContext #75

Closed vvidovic closed 4 years ago

vvidovic commented 4 years ago

Added code enabling to set custom SSLContext from Java code during Conjur class initialization. Usable in k8s/OpenShift environment to setup TLS trust with Conjur server dynamically from k8s secret and/or configmap data.

Connected to #74.

vvidovic commented 4 years ago

Thanks for the review, please let me know if I missed something. I squashed all changes to 1 commit to avoid polluting change history.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 9dc5f344 and detected 17 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 16
Clarity 1

View more on Code Climate.

sgnn7 commented 4 years ago

/approve-build 9dc5f3446422b8fa63d2a1270eb8ef41abb3a7aa

JakeQuilty commented 4 years ago

/approve-build 9dc5f3446422b8fa63d2a1270eb8ef41abb3a7aa

sgnn7 commented 4 years ago

Moved PR to a branch in parent repo and new PR has been opened for the code so that we can build it on internal infra: https://github.com/cyberark/conjur-api-java/pull/76. Closing this PR.

PS: I fixed up the comment from readme and removed the merge commit from my readme update in it.