Fix failing tests due to chromium/badssl.com#501 - Githubissues

cyberark / conjur-api-python

Python client for the CyberArk Conjur API

Apache License 2.0

8 stars 3 forks source link

Fix failing tests due to chromium/badssl.com#501 #21

Closed szh closed 2 years ago

szh commented 2 years ago

Desired Outcome

Fix SSL tests failing with SSLCertVerificationError

Implemented Changes

Temporarily commented out tests for sha384.badssl.com and sha512.badssl.com since their certs have expired and are causing false negatives. See similar PR in AWS's s2n-tls: https://github.com/aws/s2n-tls/pull/3322
Also added a basic .gitignore file to keep pycache and test artifacts out of the repo

Connected Issue/Story

N/A

Definition of Done

[x] Unit tests pass

Changelog

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[x] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[ ] These changes are part of a larger initiative with a separate security review, or
[x] There are no security aspects to these changes