JakeQuilty
commented
4 years ago @izgeri Removing bin/release was part of switching the release process to be similar to Secretless'. The release instructions are paraphrased from the Secretless release process.
Since the process changed, the old process had requirements and workflows in bin/release that did not transfer over.
bin/release:
- required local changes to "version bump files" that would get pushed with the new tag
- the new flow asks for a tag change after the "bump pr"
- committed and pushed file changed directly to master
- this isn't a standard workflow we follow
Keeping bin/release would have meant deleting almost the entire script and re-writing it to just do the tagging:
# [grab version number]
# [check if version number has changed]
git tag -a "vx.y.z" -m "vx.y.z release"
git push vx.y.z
Since the Secretless flow I was following did not use a script to do these steps, I followed that flow.
Personally, I feel like doing the tag and push steps manually creates a natural "are you sure?" process so someone with access doesn't accidentally run the release script and push a new tag without meaning to.
Would you like me to add these notes to the commit body, or is having them in the PR good enough?
izgeri
codeclimate[bot]
What does this PR do?
What ticket does this PR close?
Connected to https://github.com/cyberark/conjur-api-ruby/issues/173
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or