Closed doodlesbykumbi closed 3 years ago
That does the trick for me. I checked that the previous approach with OpenSSL::SSL::SSLContext::DEFAULT_CERT_STORE.add_file
still works, and that the new approach with Conjur.configuration.rest_client_options = { ssl_ca_file: 'my_cert.crt' }
works too. I also checked with a proxy.
Thank you !
Code Climate has analyzed commit a07c9330 and detected 43 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Duplication | 4 |
Style | 1 |
Complexity | 38 |
The test coverage on the diff in this pull request is 66.6% (50% is the threshold).
This pull request will bring the total coverage in the repository to 92.3% (0.2% change).
View more on Code Climate.
What does this PR do?
This replaces the monkey patch to RestClient::Request that made it always uses :ssl_cert_store, which polluted into usage of RestClient outside the scope of Conjur. The new approach provides a sane default that retains the previous behavior, and gives the user the ability to configure RestClient::Requests scoped only to Conjur.
What ticket does this PR close?
Connected to https://github.com/cyberark/conjur-api-ruby/issues/188
Checklists
Change log
Test coverage
Documentation
README
s) were updated in this PR, and/or there is a follow-on issue to update docs, or