Addressable gem dependency update - Githubissues

cyberark / conjur-api-ruby

Ruby client for the CyberArk Conjur API

https://rubygems.org/gems/conjur-api

Apache License 2.0

3 stars 5 forks source link

Addressable gem dependency update #199

Closed semyon-estrin closed 2 years ago

semyon-estrin commented 2 years ago

Desired Outcome

Addressable dependency changed from (~> 2.8.0) to (~2.0) to allow compatability with other gems in conjur.

Implemented Changes

Change dependency in conjur-api.gemspec

Connected Issue/Story

CyberArk internal issue link: ONYX-14705

Definition of Done

Same addressable version (2.8.0) is used within conjur-api-ruby. Dependency changed to (~> 2.0). Jenkins CI tests are green.

Changelog

[x] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: [insert issue ID]()
[x] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[ ] These changes are part of a larger initiative that will be reviewed later, or
[ ] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[x] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 908241e4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.9% (0.0% change).

View more on Code Climate.